隨記

Rationale

GitLab requires all code changes to be reviewed before merge. Code review catches bugs, ensures knowledge sharing, and maintains quality.

Requirements

  1. All merge requests must be reviewed by at least one reviewer
  2. Reviewer must approve before merge
  3. Author must address all review comments
  4. Security-sensitive changes require security team review
  5. DRI (Directly Responsible Individual) must be assigned for critical changes

Review Checklist

  • Code follows style guidelines
  • Tests are adequate (unit, integration, E2E)
  • No security vulnerabilities introduced
  • Documentation is updated
  • Changelog entry included for user-facing changes
  • Feature flags are properly managed
  • Database migrations are backward-compatible
  • Error handling is appropriate
  • Logging is sufficient for debugging

Reviewer Values

  • Be kind and constructive
  • Focus on the code, not the person
  • Explain the "why" behind suggestions
  • Approve when concerns are addressed, don't seek perfection

References